Merge pull request #978 from bullet-train-co/jeremy/remove-knapsack

Remove knapsak_pro from the roles gem
bullet-train-co · Nov 26, 2024 · d0d06d5 · d0d06d5
2 parents 731d174 + bb805a0
commit d0d06d5
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 11 deletions.
diff --git a/bullet_train-roles/Gemfile.lock b/bullet_train-roles/Gemfile.lock
@@ -100,8 +100,6 @@ GEM
       activesupport (>= 5.0)
     i18n (1.12.0)
       concurrent-ruby (~> 1.0)
-    knapsack_pro (3.1.3)
-      rake
     loofah (2.19.1)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
@@ -214,7 +212,6 @@ DEPENDENCIES
   bullet_train-roles!
   byebug (~> 11.1.0)
   factory_bot_rails (~> 6.2.0)
-  knapsack_pro (~> 3.1.0)
   minitest (~> 5.0)
   minitest-reporters
   pg (~> 1.3)

diff --git a/bullet_train-roles/Rakefile b/bullet_train-roles/Rakefile
@@ -8,5 +8,3 @@ load "rails/tasks/engine.rake"
 load "rails/tasks/statistics.rake"
 
 require "bundler/gem_tasks"
-
-KnapsackPro.load_tasks if defined?(KnapsackPro)
diff --git a/bullet_train-roles/bullet_train-roles.gemspec b/bullet_train-roles/bullet_train-roles.gemspec
@@ -28,7 +28,6 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "byebug", "~> 11.1.0"
   spec.add_development_dependency "factory_bot_rails", "~> 6.2.0"
-  spec.add_development_dependency "knapsack_pro", "~> 3.1.0"
   spec.add_development_dependency "minitest", "~> 5.0"
   spec.add_development_dependency "pg", "~> 1.3"
   spec.add_development_dependency "rails", "~> 7.0.0"

diff --git a/bullet_train-roles/test/test_helper.rb b/bullet_train-roles/test/test_helper.rb
@@ -15,11 +15,6 @@
   ActiveSupport::TestCase.fixtures :all
 end
 
-require "knapsack_pro"
-
-knapsack_pro_adapter = KnapsackPro::Adapters::MinitestAdapter.bind
-knapsack_pro_adapter.set_test_helper_path(__FILE__)
-
 require "factory_bot_rails"
 
 require_relative "../../test_support/minitest_reporters"