Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Empty examples in schemas in OpenAPI #236

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Fix: Empty examples in schemas in OpenAPI #236

merged 2 commits into from
Aug 24, 2023

Conversation

newstler
Copy link
Contributor

@newstler newstler commented Apr 9, 2023 •
edited
Loading

Sends FactoryBot examples to JbuilderSchema for proper attributes and properties examples in schemas.

This fixes empty examples in

components:
    schemas:
        XXXAttributes:
        XXXParameters:

@newstler newstler force-pushed the fix/examples-in-jbuilder-schema branch 2 times, most recently from 97e8d5d to ffd9181 Compare April 9, 2023 22:43
@newstler newstler changed the title Fix: Send FactoryBot examples to JbuilderSchema for proper attributes and properties examples in schemas Fix: Empty examples in schemas in OpenAPI Apr 22, 2023
@newstler newstler mentioned this pull request May 6, 2023
Merged
@jagthedrummer jagthedrummer force-pushed the fix/examples-in-jbuilder-schema branch from ffd9181 to 682db2a Compare August 9, 2023 21:27
@jagthedrummer
Copy link
Contributor

@newstler I just rebased this against main because I thought that it looked like it was good to go, but now it's getting some test failures. Can you look into that?

@jagthedrummer jagthedrummer force-pushed the fix/examples-in-jbuilder-schema branch from 682db2a to 6a8c0b5 Compare August 23, 2023 18:28
@newstler newstler force-pushed the fix/examples-in-jbuilder-schema branch from 6a8c0b5 to 7f0b941 Compare August 23, 2023 20:35
@newstler newstler force-pushed the fix/examples-in-jbuilder-schema branch from e7f9617 to c36a20e Compare August 23, 2023 22:28
@newstler
Copy link
Contributor Author

@jagthedrummer Fixed!

@jagthedrummer jagthedrummer merged commit 28873ec into main Aug 24, 2023
1 check passed
@jagthedrummer jagthedrummer deleted the fix/examples-in-jbuilder-schema branch August 24, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagthedrummer jagthedrummer jagthedrummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newstler @jagthedrummer