Features/add webhooks signature #292
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewculver I'm leaving this one for you since it's related to outgoing webhooks. |
|
@andrewculver asked me not to merge anything related to outgoing webhooks, so I'm going to leave this for him to review and merge. Going to convert it to a draft PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #216
This PR has an accompanying migration to merge bullet-train-co/bullet_train#785
Overview
We are adding cryptographic signature to outgoing webhooks such that the receiver can (optionally) verify to ensure that the webhook originated from a BulletTrain application (similar to Stripe webhooks).
The signature will be sent in a new header called bullet-train-signature:
Testing
Created an outgoing webhook, using pipedream for the url and triggered the event in the application to cause an outgoing webhook. Verified that the outgoing webhook contains the new signature header.