Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the base path of bullet_train when accessing documentation #314

Merged
merged 6 commits into from
Aug 23, 2023
Merged

Cache the base path of bullet_train when accessing documentation #314

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0acd6d0
Cache the base path of bullet_train for documentation
gazayas Jun 8, 2023
f0c1021
Add TODO back to documentation support
gazayas Jun 8, 2023
65a2718
Fixing Standard Ruby
gazayas Jun 8, 2023
77c298c
Add timeout to docs path cache
gazayas Aug 9, 2023
e493043
memoize the path in a constant
jagthedrummer Aug 23, 2023
9bbaed8
dang linter
jagthedrummer Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bullet_train/app/controllers/concerns/documentation_support.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
module DocumentationSupport
extend ActiveSupport::Concern

BULLET_TRAIN_BASE_PATH = `bundle show bullet_train`.chomp

def docs
target = params[:page].presence || "index"

# TODO For some reason this didn't work on Heroku.
# all_paths = ([Rails.root.to_s] + `bundle show --paths`.lines.map(&:chomp))
# @path = all_paths.map { |path| path + "/docs/#{target}.md" }.detect { |path| File.exist?(path) }

# TODO Trying to just brute force this for now.
@path = `bundle show bullet_train`.chomp + "/docs/#{target}.md"
@path = "#{BULLET_TRAIN_BASE_PATH}/docs/#{target}.md"

render :docs, layout: "docs"
end
Expand Down