-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix html option settings for objects that have multiple values #386
Conversation
@jagthedrummer Yes, I think we were getting a false positive in CI, and the Super Scaffolding partial tests were failing. I'm assuming the tests were running against released versions as opposed to the most recent changes on GitHub. I say that because I ran The other one failing right now is related to |
@gazayas Ah-ha! It all makes sense now. It's what I found in bullet-train-co/bullet_train#831. We were looking at the same thing, just coming at it from different directions. So, just kinda thinking out loud here. Does it seem reasonable to do the following?
Also open to suggestions! |
Since we can always revert things if we need to, and in the interest of getting PRs closed, I'm going to proceed with the plan I mentioned above. |
Welp, merging this didn't fix the situation in bullet-train-co/bullet_train#831. Now I'm suspecting that #334 has something to do with it. Unfortunately too much stuff has changed since we merged that and we can't just generate a revert PR for it. I'm going to try making a branch and undoing stuff in that PR by hand. |
I thought we would be ok with #317, but it turns out that merging it broke the tests.
What's happening here is that super select objects uses
html_options: {multiple: true}
whereas other objects just usemultiple: true
:It's a little difficult to tell what's going on in this portion of the transformer, but I hope this comment helps to clear things up a little bit.