Revert #334 - Themes localization #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 294827a.
…ng and fall back to legacy parsing" This reverts commit 4415e40.
…zone_name_to_id" This reverts commit fb126f3.
This reverts commit b5639dd.
This reverts commit 8b7b932.
This reverts commit db5e12a.
This reverts commit 91bccbe.
…/cancel label override" This reverts commit 6215c33.
…ale helper" This reverts commit ba75242.
…ime" This reverts commit 1388671.
This reverts commit 67ac4ae.
This reverts commit 671a8ca.
This reverts commit 51d156c.
This reverts commit 6c1532b.
This reverts commit 20d5a24.
This reverts commit dfbd84f.
This reverts commit b9453e4.
This reverts commit 94d5307.
This reverts commit 6b6c50a.
This reverts commit cfa09ee.
This reverts commit be3492d.
…controller" This reverts commit fbf97ed.
This reverts commit fbaf6d3.
…ield.html.erb" This reverts commit 0a9f2bd.
|
Here's a PR to revert this revert: #390 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #334 as it is causing test failures in the Minitest For Super Scaffolding tests in the starter repo when run against the
mainbranch ofcore.And they seem to be legitimate failures. With my starter repo linked to all of my local copies of everything in
coreI can reproduce the test failures. And when I enable Magic Test to pause the test just before the failure I can see that the date and date/time pickers are no longer working.After preparing this PR my local tests are passing again, and the date and date/time pickers are working again. It also gets tests passing again in CI. https://app.circleci.com/pipelines/github/bullet-train-co/bullet_train/1981/workflows/4f3dcbe3-8ff4-4f55-8b13-9eea7f560494
@3pns I think the goals you outlined in #334 are great and I think we should adopt them as goals, but it seems the implementation needs a little more work. If you'd like to pick it back up that would be great. If you don't have time I'll put it on my (already large) list.