Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptions initializer from starter repository #580

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

gazayas
Copy link
Contributor

@gazayas gazayas commented Sep 27, 2023

@jagthedrummer
Copy link
Contributor

@gazayas is there a reason that these need to be in an initializer instead of each error living in it's own class somewhere? I'm thinking maybe bullet_train/app/errors? Or perhaps somewhere in bullet_train/lib?

@gazayas
Copy link
Contributor Author

gazayas commented Sep 27, 2023

@jagthedrummer No reason besides it was originally there in the first place, and I wasn't the one who originally made the file. I like the file being in bullet_train/lib, so I moved it over.

By the way the tests are failing in the starter repository because I accidentally named the branches differently...

@gazayas
Copy link
Contributor Author

gazayas commented Sep 27, 2023

Will look into the failure that's coming up here, might be legit. Seems like the RemovingLastTeamException is not getting picked up.

@gazayas
Copy link
Contributor Author

gazayas commented Sep 28, 2023

This one should be good to go. The tests are failing locally, but pass with the fix in bullet-train-co/bullet_train#1044

@jagthedrummer jagthedrummer merged commit fb3211b into main Sep 28, 2023
5 checks passed
@jagthedrummer jagthedrummer deleted the remove-exceptions-initializer branch September 28, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants