Fix association names when scaffolding join models if they don't match the table name #848
Conversation
jagthedrummer
force-pushed
the
jeremy/join-model-attribute-naming
branch
from
ab7d656
to
057e7ef
Compare
jagthedrummer
changed the title
| @@ -58,6 +58,20 @@ def association_class_name | |||
| name.split("_id").first | |||
| end | |||
|
|
|||
| def association_name | |||
| association_class_name.tableize | |||
There was a problem hiding this comment.
tableize will also pluralize, which I don't know if we want for belongs_to/has_one associations. For those, we'd probably want underscore.tr("/", "_").
There was a problem hiding this comment.
🤔 Hmm, good point. Currently I think this method is only being called in places where we have a has_many or has_many through: relationship, but I can see how this would be confusing and potentially lead to problems down the road. I'll clean it up a bit.
| def class_name_matches? | ||
| # if namespaces are involved, just don't... | ||
| # TODO: I'm not entirely sure that extracting this conditional was the right thing to do. | ||
| # Are there scenarios where we want to assume a match even when namespaces are involved? | ||
| if options[:class_name].include?("::") | ||
| return false | ||
| end | ||
| name_without_id.tableize == options[:class_name].tableize.tr("/", "_") | ||
| end |
There was a problem hiding this comment.
What are the cases that this logic is for, I'm having a bit of a hard time understanding it?
There was a problem hiding this comment.
@kaspth This is used in situations where you're scaffolding a relationship with a name that doesn't match the name of the table/model you're relating to. See the main description in this issue for an example: bullet-train-co/bullet_train#1508 (comment)
|
Ok, there's a whole bunch of code that I haven't really looked at and that it'd take me some more time to dive into, so feel free to forward without me :) |
jagthedrummer
force-pushed
the
jeremy/join-model-attribute-naming
branch
from
be692ca
to
52dc390
Compare
Fixes the association naming problem in: bullet-train-co/bullet_train#1508
I'm going to create a separate issue about the incorrect
valid_method that's added on one side of the association.