Add a generator for AuditLogs #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we transitioned to using generators we didn't include one for AuditLogs. This is just a quick and dirty PR to get things working. There may be additional options we should add (or existing options we should remove) in the future as these get used.
jagthedrummer
added a commit
to bullet-train-pro/bullet_train-audit_logs
that referenced
this pull request
Nov 15, 2024
Currently it's not possible to generate an audit log. This PR along with this one from `core` (bullet-train-co/bullet_train-core#945) fix that particulart problem. This is really just a quick and dirty fix to get things working as quickly as possible. Eventually we should remove this method and use whatever the new standard method is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we transitioned to using generators we didn't include one for AuditLogs.
This is just a quick and dirty PR to get things working. There may be additional options we should add (or existing options we should remove) in the future as these get used.