Better handling for empty values in some attributes #960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247
The attribute display for
date
,date_and_time
, andboolean_button
did some unexpected things if the attribute in question was empty.boolean_button
would display a label, but no value.date
anddate_and_time
would display the word "Never" but without a labelAll of the other attribute type don't display anything if their value is empty.
In order to allow apps to continue to show those values even if they are empty (but now with a label) those attribute partials now accept a
display_when_blank
option. It can be used like this:Before:
After, default behavior:
After, passing
display_when_blank: true
: