Allow address fields to be disabled #974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagthedrummer
commented
Nov 26, 2024
| .select2-container--default.select2-container--disabled .select2-selection--multiple{ | ||
| @apply bg-slate-200 dark:bg-slate-700 hover:bg-slate-200 hover:dark:bg-slate-700 | ||
| } | ||
|
|
There was a problem hiding this comment.
This makes it so that disabled super selects have the same background colors as other disabled inputs. Without this disabling the address looks like this:
…up with the same id...
jagthedrummer
commented
Nov 26, 2024
| postal_code_options ||= {} | ||
| postal_code_options[:data] ||= {} | ||
| region_html_options ||= {} | ||
| region_html_options[:data] ||= {} |
There was a problem hiding this comment.
We need to create separate options hashes for each individual input because if we pass the same hash to each input they all end up with the same id on the actual input elements. The duplicate id thing happens because of this line:
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to pass
options: {disabled: true}to disable the entire address field.Like this:
It disabled every input that's a part of the address, regardless of whether the address has been populated previously.
Empty initial state:
With a previously populated address:
This finally fixes #573