Skip to content

Commit

Permalink
Enable password field tests, move Super Scaffolding file tests (#728)
Browse files Browse the repository at this point in the history
* Move the TestFile Super Scaffolding test

* Uncomment Super Scaffolding tests for password field

* Change order of super scaffolding system tests

* Specifiy single option selection with same text as another element

* Fixing Standard Ruby

* Add TODO for partial system tests

* Remove conflicts

* Remove duplicated test

* Remove unneeded constant
  • Loading branch information
gazayas authored Aug 3, 2023
1 parent eacbc59 commit b96213e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions test/bin/setup-super-scaffolding-system-test
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ fi
if [ -z "${CIRCLE_NODE_INDEX}" ] || [ "${CIRCLE_NODE_INDEX}" == "6" ]; then
bundle exec spring rails g model TestFile team:references name:string foo:attachment
bin/super-scaffold crud TestFile Team name:text_field foo:file_field --sidebar="ti.ti-tag"
# TODO Write an actual test for this in `test/system/super_scaffolding_test.rb`.

bundle exec spring rails g model ColorPicker team:references color_picker_value:string
bin/super-scaffold crud ColorPicker Team color_picker_value:color_picker --sidebar="ti.ti-tag"
Expand All @@ -112,7 +111,6 @@ else
fi

# TODO: Generate these in parallel.
# TODO: Super Scaffold password_field partials correctly.
bundle exec spring rails g model PartialTest team:references \
text_field_test:string \
boolean_test:boolean \
Expand Down
3 changes: 2 additions & 1 deletion test/system/super_scaffolding_partial_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ def setup
# File partial
attach_file("test/support/foo.txt", make_visible: true)
# Single Option partial
choose("One")
# TODO: Not sure why we have to specify this, but not the other button with "one".
page.all("input").find { |node| node.value == "one" }.click
# Multiple Option partial
check("One")
check("Three")
Expand Down

0 comments on commit b96213e

Please sign in to comment.