Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolver system test for ejected themes #1017

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

gazayas
Copy link
Contributor

@gazayas gazayas commented Sep 20, 2023

Closes #1008.

Works if:

  1. No files have been ejected
  2. If just the one file has been ejected with bin/resolve shared/attributes/text --eject
  3. If a custom theme has been ejected i.e. - rake bullet_train:themes:light:eject[foo]

@gazayas gazayas marked this pull request as ready for review September 20, 2023 11:25
@jagthedrummer jagthedrummer merged commit 930de8f into main Sep 20, 2023
8 checks passed
@jagthedrummer jagthedrummer deleted the fixes/resolver-system-test branch September 20, 2023 15:21
newstler pushed a commit that referenced this pull request Oct 9, 2023
* Fix resolver system test for ejected themes

* Write correct relative path for resolver test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolver system test fails with ejected template
2 participants