Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Super Scaffolding system test setup for automated rails g commands #1030

Merged
merged 18 commits into from
Oct 4, 2023

Conversation

gazayas
Copy link
Contributor

@gazayas gazayas commented Sep 22, 2023

@gazayas
Copy link
Contributor Author

gazayas commented Sep 25, 2023

I made some progress on this one. The remaining models that are commented out in the Super Scaffolding system test setup script have the same namespace problem that I handled in bullet-train-co/bullet_train-core#503. I solved it with the following code.

https://github.com/bullet-train-co/bullet_train-core/blob/main/bullet_train-super_scaffolding/lib/bullet_train/super_scaffolding/scaffolders/crud_scaffolder.rb#L40-L52

I'm hoping to implement something similar to account for the namespaces in the system test here, because you can see by the following commands that references attribute name doesn't use the entire parent name.

bundle exec spring rails g model Personality::Note disposition:references name:string
bin/super-scaffold crud Personality::Note Personality::Disposition,Team name:text_field description:trix_editor

@gazayas gazayas marked this pull request as ready for review September 26, 2023 12:13
@jagthedrummer jagthedrummer merged commit 6e538a4 into main Oct 4, 2023
8 checks passed
@jagthedrummer jagthedrummer deleted the features/generate-models-when-super-scaffolding branch October 4, 2023 15:12
newstler pushed a commit that referenced this pull request Oct 9, 2023
…mmands (#1030)

* Temporarily comment out portion of system test setup

* Temporarily comment out portion of system test setup

* Temporarily add spring

* Temporarily use local gems

* Remove unneeded rails g model in test setup

* Update test setup for scaffolders on first node

* Uncomment join-model related test setup

* Uncomment Projects::Step and Objective in test setup script

* Uncomment Insight and Personality::CharacterTrait in test setup script

* Uncomment TestFile and ColorPicker in test setup script

* Uncomment PartialTest in test setup script

* Uncomment Personality::Disposition and Personality::Note in test setup script

* Uncomment Personality::Observation and Personality::Reactions::Response in test setup script

* Remove unneeded rails g commands from system test setup

* Remove rails g for Projects::AppliedTag in system test setup script

* Reset local gems

* Remove spring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants