Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary fix to enable headless invitation lists tests #1034

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

gazayas
Copy link
Contributor

@gazayas gazayas commented Sep 25, 2023

Fixes #1029.

For some reason in the Invitation List tests only, we get the following value.

     5: def setup
 =>  6:   binding.pry
     7: 
     8:   @current_bulk_invitations_setting = nil
     9:   BulletTrain.configure do |config|
    10:     @current_bulk_invitations_setting = config.enable_bulk_invitations
    11:     config.enable_bulk_invitations = true
    12:   end
    13: end

[1] pry(#<InvitationListsTest>)> Capybara.current_driver
=> :selenium

However, in application_system_test_case.rb, we only set one of these two keys explicitly.

Capybara.javascript_driver = ENV["MAGIC_TEST"].present? ? :selenium_chrome : :selenium_chrome_headless
Capybara.default_driver = ENV["MAGIC_TEST"].present? ? :selenium_chrome : :selenium_chrome_headless

I'm guessing this is related to #1028 especially since it's a Selenium::Webdriver error that's being raised, but I'll have to investigate further to make sure.

@gazayas
Copy link
Contributor Author

gazayas commented Sep 25, 2023

Passing consistently now

スクリーンショット 2023-09-25 19 49 22

Copy link
Contributor

@jagthedrummer jagthedrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, good find! I don't think it would have even occurred to me to check that.

@jagthedrummer jagthedrummer merged commit 4558a1f into main Sep 25, 2023
8 checks passed
@jagthedrummer jagthedrummer deleted the fixes/headless-system-tests branch September 25, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System tests have started always opening a visible browser
2 participants