Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace a lingering instance of resize_for #1095

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

jagthedrummer
Copy link
Contributor

We cleaned up most of these in
#720 but the conversion script couldn't see this one.

Fixes #1094

We cleaned up most of these in
#720 but the
conversion script couldn't see this one.
Copy link
Contributor

@kaspth kaspth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Now that we've got the tests updated, I wonder if we should change the deprecation message to say use resize_display instead?

@jagthedrummer jagthedrummer merged commit a20661a into main Oct 17, 2023
8 checks passed
@jagthedrummer jagthedrummer deleted the jeremy/fix-animations-test branch October 17, 2023 15:06
@jagthedrummer
Copy link
Contributor Author

Now that we've got the tests updated, I wonder if we should change the deprecation message to say use resize_display instead?

Hmmm.... I'm really not sure about that.

If people have been keeping up on versions that could make sense, but I'm concerned about what happens to people that haven't been keeping up.

Like imagine someone is on 1.2.x (or earlier) and has written their own system tests that were using the old pattern that we replaced with device_test. They'd have some instances where the existing deprecation message is telling them to do the right thing.

Maybe we should change the message to say that they could try running the helper to clean it up, and we could also include a link to a page with more details about the change and how to manually fix any lingering references?

@kaspth
Copy link
Contributor

kaspth commented Oct 18, 2023

Maybe we should change the message to say that they could try running the helper to clean it up, and we could also include a link to a page with more details about the change and how to manually fix any lingering references?

This sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lingering use of resize_for
2 participants