Write more precise db schema check #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to make sure it's clear, this is pointing to |
kaspth
reviewed
Nov 27, 2023
depfu
bot
force-pushed
the
depfu/update/group/rails-7.1.2
branch
from
56e5b09
to
a9346f4
Compare
jagthedrummer
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Nice work on this @gazayas! I'm gonna merge it, and then I think that depfu will notice the update on the rails upgrade PR, and then if tests pass I think it'll automatically merge it.
Soooo....
https://butt.holdings/
depfu
bot
force-pushed
the
depfu/update/group/rails-7.1.2
branch
from
a9346f4
to
5d513f2
Compare
jagthedrummer
merged commit 003e058
into
depfu/update/group/rails-7.1.2
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again this is failing due to our current CI credit status, but the db schema check works for me. I wrote a comment in #1150 explaining a little bit in more detail.