Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust instructions for tweaking logo height #1217

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

pascallaliberte
Copy link
Member

@pascallaliberte pascallaliberte commented Nov 30, 2023

Fixes bullet-train-co/bullet_train-core#708

Adjusts comments in initializers to help tweak logo height.

Joint PR: bullet-train-co/bullet_train-core#709

@@ -6,5 +6,5 @@
# The orientation of the navbar.
# BulletTrain::Themes::Light.navigation = :left
#
# The logo shown in the navbar.
# The logo shown in the navbar. To tweak further, run `bin/resolve shared/menu/logo --eject`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Excellent pointer!

@jagthedrummer jagthedrummer merged commit 89927ab into main Dec 4, 2023
24 checks passed
@jagthedrummer jagthedrummer deleted the fix/logo-height-on-workflow-pages branch December 4, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix use of logo_height theme property on workflow pages, make instructions clearer?
2 participants