Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system tests for when billing is enabled #787

Merged

Conversation

gazayas
Copy link
Contributor

@gazayas gazayas commented May 15, 2023

Closes #782.

Since our billing page has changed, we needed to update the test helper that fills out the necessary fields to subscribe to a plan.

Old

pricing

New

new_pricing

There are still a bunch of system tests that need to be updated, so I'll mark the PR as ready for review once those are done.

@gazayas
Copy link
Contributor Author

gazayas commented May 15, 2023

Because the pricing page can take a while to finish and then redirect, I had to add some extra sleep calls to make sure everything passed. The tests now unfortunately take a while when billing is enabled, but I don't think we can do much about it if request to subscribe to the plan takes a long time.

If anything I can double check on the numbers and try to cut them down if necessary.

@gazayas gazayas marked this pull request as ready for review May 15, 2023 13:31
@gazayas
Copy link
Contributor Author

gazayas commented May 15, 2023

Actually, now that I'm thinking about it we might have to remove free_trial? and use freemium_enabled? exclusively. I think I'll run tests again with the latter and push that if it aligns with how we want to handle free subscriptions.

@gazayas
Copy link
Contributor Author

gazayas commented May 16, 2023

Ok, I made the sleep times shorter, and since we don't go to the pricing page when a freemium is enabled, I removed the unnecessary checks from the application system case because we skip this inside each system test anyways.

@jagthedrummer
Copy link
Contributor

@gazayas This looks great! Can you resolve the conflicts?

@gazayas
Copy link
Contributor Author

gazayas commented Aug 3, 2023

@jagthedrummer Done!

@jagthedrummer jagthedrummer merged commit eacbc59 into bullet-train-co:main Aug 3, 2023
@gazayas gazayas deleted the fixes/update-billing-test-helper branch August 4, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding the billing gems breaks the system test suite
2 participants