Fix conflict with Content Security Policy headers #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pustomytnyk
commented
Jul 11, 2022
| @@ -44,7 +44,13 @@ With this we will: | |||
| Finally, because it’s hard for us to do automatically, you will need to add the following before any closing `</head>` tags in any of the files in `app/views/layouts`: | |||
|
|
|||
| ```ruby+erb | |||
| <%= render 'magic_test/support' if Rails.env.test? %> | |||
There was a problem hiding this comment.
The condition is already inside partial
pustomytnyk
commented
Jul 11, 2022
| @@ -21,8 +21,8 @@ def install | |||
| gsub_file "test/system/basics_test.rb", "visit basics_url", "visit root_url" | |||
| gsub_file "test/system/basics_test.rb", 'assert_selector "h1", text: "Basic"', "magic_test" | |||
|
|
|||
| gsub_file "test/application_system_test_case.rb", "using: :headless_chrome", "using: (ENV['SHOW_TESTS'] ? :chrome : :headless_chrome)" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
<script>withjavascript_tagto supportnonce: trueif required by Content Security Policy headers. Tested proper render in Rails 5.1 and 7.