New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the `flush` method #99

Open

gazayas wants to merge 1 commit into main from features/notify-when-js-is-empty

gazayas commented Jun 27, 2023

If no JavaScript is recorded, output is simply an empty array, so the following else statement never gets the chance to run:

if output
  # ...
else
  puts "`window.testingOutput` was empty in the browser. Something must be wrong on the browser side."
end

I shifted things around so we notify the user that no JavaScript was recorded.


          Refactor the flush method

c463fdc

gazayas mentioned this pull request

Refactor the flush method gazayas/magic_test#6

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet