Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NovoOverlay): contextual custom overlay containers #1639

Open
wants to merge 10 commits into
base: next
Choose a base branch
from
Open

feat(NovoOverlay): contextual custom overlay containers #1639

wants to merge 10 commits into from

Conversation

dvoegelin
Copy link
Collaborator

@dvoegelin dvoegelin commented Dec 17, 2024 •
edited
Loading

Description

  • adding accessible overlay ref on modal service
  • adding support for contextual custom overlay containers to allow for multiple overlay contexts
  • updating the side of the filter icon the data table filter overlay attaches to, to avoid the overlays popping up under left-side menus and bowling alleys

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@dvoegelin dvoegelin self-assigned this Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 27d3335):

https://novo-elements--pr1639-overlay-ref-49ul0sk7.web.app

(expires Mon, 10 Feb 2025 13:41:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@dvoegelin dvoegelin changed the title feat(NovoModalService): adding accessible overlay ref on modal service feat(NovoOverlay): contextual custom overlay containers Jan 30, 2025
dvoegelin and others added 3 commits January 30, 2025 13:59
@dvoegelin
Merge branch 'next' into overlay-ref
4b533f6
@monroepe
feat(NovoDataTablePagination): Add option to show the total number of… (
87f65d7 
#1648)

* feat(NovoDataTablePagination): Add option to show the total number of records in a table next to pagination

* feat(NovoDataTablePagination): Update to always show total in pagination when in footer

* Updating logic to not show if total is null or undefined

* Update check to see if pagination is loading
@dvoegelin
Merge branch 'next' into overlay-ref
27d3335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dvoegelin dvoegelin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvoegelin @monroepe