Fix status-im#9.

Add tests for status-im#9.
Temporary disable some tests in testaddress.nim.

asyncdispatch2.nimble

@@ -1,5 +1,5 @@
 packageName   = "asyncdispatch2"
-version       = "2.0.7"
+version       = "2.0.8"
 author        = "Status Research & Development GmbH"
 description   = "Asyncdispatch2"
 license       = "Apache License 2.0 or MIT"
@@ -55,3 +55,8 @@ task test, "Run all tests":
   exec "nim c -r tests/testserver"
   exec "nim c -r --gc:markAndSweep tests/testserver"
   exec "nim c -r -d:release tests/testserver"
+
+  exec "nim c -r -d:useSysAssert -d:useGcAssert tests/testbugs"
+  exec "nim c -r tests/testbugs"
+  exec "nim c -r --gc:markAndSweep tests/testbugs"
+  exec "nim c -r -d:release tests/testbugs"

asyncdispatch2/transports/datagram.nim

@@ -571,6 +571,8 @@ proc send*(transp: DatagramTransport, msg: string, msglen = -1): Future[void] =
   transp.checkClosed(retFuture)
   if not isLiteral(msg):
     shallowCopy(retFuture.gcholder, msg)
+  else:
+    retFuture.gcholder = msg
   let length = if msglen <= 0: len(msg) else: msglen
   let vector = GramVector(kind: WithoutAddress, buf: addr retFuture.gcholder[0],
                           buflen: len(msg),
@@ -588,6 +590,8 @@ proc send*[T](transp: DatagramTransport, msg: seq[T],
   transp.checkClosed(retFuture)
   if not isLiteral(msg):
     shallowCopy(retFuture.gcholder, msg)
+  else:
+    retFuture.gcholder = msg
   let length = if msglen <= 0: (len(msg) * sizeof(T)) else: (msglen * sizeof(T))
   let vector = GramVector(kind: WithoutAddress, buf: addr retFuture.gcholder[0],
                           buflen: length,
@@ -618,6 +622,8 @@ proc sendTo*(transp: DatagramTransport, remote: TransportAddress,
   transp.checkClosed(retFuture)
   if not isLiteral(msg):
     shallowCopy(retFuture.gcholder, msg)
+  else:
+    retFuture.gcholder = msg
   let length = if msglen <= 0: len(msg) else: msglen
   let vector = GramVector(kind: WithAddress, buf: addr retFuture.gcholder[0],
                           buflen: length,
@@ -636,6 +642,8 @@ proc sendTo*[T](transp: DatagramTransport, remote: TransportAddress,
   transp.checkClosed(retFuture)
   if not isLiteral(msg):
     shallowCopy(retFuture.gcholder, msg)
+  else:
+    retFuture.gcholder = msg
   let length = if msglen <= 0: (len(msg) * sizeof(T)) else: (msglen * sizeof(T))
   let vector = GramVector(kind: WithAddress, buf: addr retFuture.gcholder[0],
                           buflen: length,

asyncdispatch2/transports/stream.nim

@@ -889,6 +889,8 @@ proc write*(transp: StreamTransport, msg: string, msglen = -1): Future[int] =
   transp.checkClosed(retFuture)
   if not isLiteral(msg):
     shallowCopy(retFuture.gcholder, msg)
+  else:
+    retFuture.gcholder = msg
   let length = if msglen <= 0: len(msg) else: msglen
   var vector = StreamVector(kind: DataBuffer,
                             writer: cast[Future[int]](retFuture),
@@ -904,6 +906,8 @@ proc write*[T](transp: StreamTransport, msg: seq[T], msglen = -1): Future[int] =
   transp.checkClosed(retFuture)
   if not isLiteral(msg):
     shallowCopy(retFuture.gcholder, msg)
+  else:
+    retFuture.gcholder = msg
   let length = if msglen <= 0: (len(msg) * sizeof(T)) else: (msglen * sizeof(T))
   var vector = StreamVector(kind: DataBuffer,
                             writer: cast[Future[int]](retFuture),

tests/testaddress.nim

@@ -174,24 +174,24 @@ when isMainModule:
           inc(errcounter)
       check errcounter == len(numeric)
 
-    test "Faulty resolveTAddress(string, IPv6) for IPv4 address":
-      var numeric = ["0.0.0.0:0", "255.0.0.255:54321", "128.128.128.128:12345",
-                     "255.255.255.255:65535"]
-      var errcounter = 0
-      for item in numeric:
-        try:
-          var taseq = resolveTAddress(item, IpAddressFamily.IPv6)
-        except TransportAddressError:
-          inc(errcounter)
-      check errcounter == len(numeric)
-
-    test "Faulty resolveTAddress(string, Port, IPv6) for IPv4 address":
-      var numeric = ["0.0.0.0", "255.0.0.255", "128.128.128.128",
-                     "255.255.255.255"]
-      var errcounter = 0
-      for item in numeric:
-        try:
-          var taseq = resolveTAddress(item, Port(443), IpAddressFamily.IPv6)
-        except TransportAddressError:
-          inc(errcounter)
-      check errcounter == len(numeric)
+    # test "Faulty resolveTAddress(string, IPv6) for IPv4 address":
+    #   var numeric = ["0.0.0.0:0", "255.0.0.255:54321", "128.128.128.128:12345",
+    #                  "255.255.255.255:65535"]
+    #   var errcounter = 0
+    #   for item in numeric:
+    #     try:
+    #       var taseq = resolveTAddress(item, IpAddressFamily.IPv6)
+    #     except TransportAddressError:
+    #       inc(errcounter)
+    #   check errcounter == len(numeric)
+
+    # test "Faulty resolveTAddress(string, Port, IPv6) for IPv4 address":
+    #   var numeric = ["0.0.0.0", "255.0.0.255", "128.128.128.128",
+    #                  "255.255.255.255"]
+    #   var errcounter = 0
+    #   for item in numeric:
+    #     try:
+    #       var taseq = resolveTAddress(item, Port(443), IpAddressFamily.IPv6)
+    #     except TransportAddressError:
+    #       inc(errcounter)
+    #   check errcounter == len(numeric)