Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working on issue 72 #73

Closed
wants to merge 2 commits into from
Closed

working on issue 72 #73

wants to merge 2 commits into from

Conversation

burner
Copy link
Owner

@burner burner commented Mar 31, 2021

Fixes #72

@burner
Copy link
Owner Author

burner commented Mar 31, 2021

@schveiguy could you please take a look at this.
ldc segfault in the reflection code you changed. I got it working again https://github.com/burner/graphqld/actions/runs/704821673, but its not really nice, nor the place, but I would like to build our work project with ldc again.

@@ -24,7 +49,8 @@ package struct SchemaReflection(Schema) {
}

string[TypeInfo] classes;
string[][TypeInfo] derivatives;
//string[][TypeInfo] derivatives;
TypeDerivatives[] derivatives;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does string[][TypeInfo] crash, but not string[TypeInfo]?

I'll have to install ldc to test this locally and find the segfault. My guess is this is not really the problem, but something that's uncovered by a particular configuration.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know either, I guess something is wrong in the druntime for ldc, but I haven't had time to reduce it yet.
And this hack works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it, see issue comment. It was not an issue of the AA failing, it was an issue of TypeInfo_Interface.name being completely invalid (the hash is based on the name).

I recommend waiting for a fix, and in the meantime limit to ldc 1.24.0

@burner
Copy link
Owner Author

burner commented Apr 4, 2021

@schveiguy thank you

@burner burner closed this Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build failes with ldc
2 participants