Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ability to override authenticators #18

Merged
merged 3 commits into from
Jan 29, 2024
Merged

remove ability to override authenticators #18

merged 3 commits into from
Jan 29, 2024

Conversation

ash-burnt
Copy link
Contributor

No description provided.

BurntVal
BurntVal approved these changes Jan 25, 2024
View reviewed changes
Copy link

@BurntVal BurntVal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm not too familiar with rust standards but looks reasonable

@ash-burnt
Copy link
Contributor Author

Passes integration tests: burnt-labs/xion#160

@ash-burnt ash-burnt self-assigned this Jan 27, 2024
@ash-burnt ash-burnt merged commit 0e8b099 into main Jan 29, 2024
2 checks passed
@ash-burnt ash-burnt deleted the chore/remove-override branch January 29, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntVal BurntVal BurntVal approved these changes

@edjroz edjroz edjroz approved these changes

@Peartes Peartes Awaiting requested review from Peartes

Assignees

@ash-burnt ash-burnt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ash-burnt @edjroz @BurntVal