Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logo display error #38

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix logo display error #38

wants to merge 6 commits into from

Conversation

wy414012
Copy link

This submission is mainly for the Chinese setting of the page, as well as fixing the logo.

Repair logo no display configuration pool binding page configuration China Tencent community exchange join address, language setting Chinese.
@harryjph
Copy link
Contributor

Sorry for the delay in addressing this, I will take a look now.

@harryjph
Copy link
Contributor

The logo should be placed next to the jar file and its path, relative or absolute, specified in the properties. Are the only other changes translation to chinese?

@wy414012
Copy link
Author

Sorry, the response is slow and the Chinese translation is complete. I really don't want to specify too many absolute paths in the Java project source. It might be more reasonable to set it in the wep front-end directory. After the automatic deployment on the Java server, operation and maintenance work. You only need to replace the microtag file and then flush the cache. After replacing an absolute path, you cannot keep it in uninterrupted mode. @harry1453

@harryjph
Copy link
Contributor

Ok. I'm not sure what you want me to do with this. Not only does it have serious conflicts with master (We are no longer using JS), you have removed the english version instead of adding i18n or similar. Additionally, your editor seems to have tainted every file you touched, making it very very difficult to view what was actually changed...

@wy414012
Copy link
Author

@harry1453 I have re-clone the branch and made the version by adding the language switch, which is about to be completed and pushed after completion.

@harryjph
Copy link
Contributor

harryjph commented Aug 9, 2019

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants