Skip to content

Commit

Permalink
Add resub cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
DavisVaughan committed Sep 7, 2017
1 parent 3ff1ed1 commit 3cf0a78
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
## Resubmission
This is a resubmission. In this version I have:

* Written package names in the DESCRIPTION Description in single quotes. Note that `tibbles` is not a package name in itself (while 'tibble' is) so I did not single quote that.

* Attempted to remove all double spaces in the DESCRIPTION Description. I had followed the 4 spaces guideline but it seems to be adding an extra space. I now align all new lines under the 's' in 'Description' like how it is done in R Extensions.

* Looked at the reexports.Rd file. I cannot figure out what is wrong with the aliases. I regenerated it using `devtools::document()` but got the exact same file. I compared with `tidygraph` which does a similar thing but they look the same. I built the package and looked at the documentation page ?reexports and all of the links work correctly. Can you help me?

## Release Summary
This is the initial release of tibbletime.

Expand Down

0 comments on commit 3cf0a78

Please sign in to comment.