Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of non-standard EST time zone from tests #106

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

DavisVaughan
Copy link
Collaborator

@DavisVaughan DavisVaughan commented Dec 3, 2024

Dear maintainer,

Please see the problems shown on
<https://cran.r-project.org/web/checks/check_results_tibbletime.html>.

The errors on the Debian check systems are from a recent system upgrade
to tzdata 2024b which did

   Names present only for compatibility with UNIX System V
   (last released in the 1990s) have been moved to 'backward'.

which includes CET, CST6CDT, EET, EST*, HST, MET, MST*, PST8PDT, and
WET.

Debian ships the names in 'backward' in a separate package tzdata-legacy
which is not installed "by default".

The comments in the tzdata 'backward' file say

# Although this file is optional and tzdb will work if you omit it by
# building with 'make BACKWARD=', in practice downstream users
# typically use this file for backward compatibility.

so clearly one cannot unconditionally assume that the backward
compatibility names will work.

Can you please change your code (typically tests) so that they do not
fail when the backward compatibility names are not available?

Please correct before 2024-12-09 to safely retain your package on CRAN.

Best wishes,
The CRAN Team

@DavisVaughan DavisVaughan merged commit b591ca3 into master Dec 3, 2024
12 checks passed
@DavisVaughan DavisVaughan deleted the fix/est-non-standard-tz branch December 3, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant