Fix future_frame()
failure for single observations
#142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108
Allows
tk_make_future_timeseries()
to work with length one vectors which is the source of thefuture_frame()
failure. Currentlytk_make_future_timeseries()
tries to infer the series frequency with the median time difference. For length one vectors this fix sets the frequency as one unit of the datatype (i.e.Date
->1 day
).This also required an update to
tk_get_timeseries_summary()
which currently returnsscale = "second"
for all length 1 vectors.Admittedly after implementing I'm not sure this is the best solution for
future_frame()
since it can cause some odd behavior if the frequency isn't really 1 unit of the datatype but you could only know it by looking across groups: