Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements:
Given the user is viewing the map, when they filter out bins, then the filtered-out bins map markers are kept on the map but transparent
Given the user is viewing the map and filters, when the bins are part of the current filter, then their bin map markers remain coloured.
Dev Notes:
The app had been developed with the idea that sensors that are filtered out are removed from viewing/use. Now that we want to show all sensors and just lower the opacity of the ones that are filtered out, we needed to do some refactoring in our code to accomodate.
Refactoring includes:
app_vue/src/utils/mapMarkerHelper.js
to be more simplistic in useage (less hardcoding strings)low-opacity
css classresult: