Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mk filtered #101

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Mk filtered #101

merged 7 commits into from
Oct 5, 2023

Conversation

monicakochofar
Copy link
Contributor

@monicakochofar monicakochofar commented Oct 5, 2023

Requirements:
Given the user is viewing the map, when they filter out bins, then the filtered-out bins map markers are kept on the map but transparent
Given the user is viewing the map and filters, when the bins are part of the current filter, then their bin map markers remain coloured.

Dev Notes:
The app had been developed with the idea that sensors that are filtered out are removed from viewing/use. Now that we want to show all sensors and just lower the opacity of the ones that are filtered out, we needed to do some refactoring in our code to accomodate.
Refactoring includes:

  • renaming variables
  • removing unused variables
  • refactoring app_vue/src/utils/mapMarkerHelper.js to be more simplistic in useage (less hardcoding strings)
  • bin icons that are low opacity are now marked with low-opacity css class

result:

image

@monicakochofar monicakochofar marked this pull request as ready for review October 5, 2023 18:20
@monicakochofar monicakochofar merged commit 657331d into develop Oct 5, 2023
1 check passed
@monicakochofar monicakochofar deleted the mk-filtered branch October 6, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant