chore: remove SS and rfs from the code base #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| for (const sensorId in responseJson.sensationalSensors) { | ||
| sensorsArray.push(responseJson.sensationalSensors[sensorId]); | ||
| } |
There was a problem hiding this comment.
right this is referencing the old react code which is not in use! should we add more red here and delete the react /app folder too? @mikevespi
cc: @BallardRobinett
There was a problem hiding this comment.
yeah I think it would make sense to just the whole /app folder if possible
| @@ -24,7 +24,7 @@ sleep .5 | |||
| echo "looking up docker containers..." | |||
| docker container ls -a | |||
| sleep .5 | |||
| if [ "$( docker inspect --format '{{json .State.Running}}' real-fake-sensors )" = "true" ] && [ "$( docker inspect --format '{{json .State.Running}}' sensational-sensors )" = "true" ]; | |||
There was a problem hiding this comment.
nice catch on this!
monicakochofar
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With real sensor data coming into the system we no longer need Real Fake Sensors and Sensational Sensors in the code base.