π Fix: Resolve issue with button variant detection #965
lint-style.yml
on: push
pre-commit
4m 13s
commitlint
11s
Annotations
1 error and 4 warnings
commitlint
You have commit messages with errors
β§ input: π Fix: Resolve issue with button variant detection
π Problem:
The previous code did not handle the case where 'args.variant' was undefined, leading to a 'Cannot read properties of undefined' error.
π οΈ Solution:
Added a check to ensure 'args.variant' is defined before using it in the conditional logic. If 'args.variant' is undefined, it defaults to an empty string, preventing the error and allowing proper detection of the variant.
π Impact:
This fix ensures that the button variant detection works correctly, providing a smoother user experience and preventing potential errors.
β body's lines must not be longer than 100 characters [body-max-line-length]
β subject may not be empty [subject-empty]
β type may not be empty [type-empty]
β found 3 problems, 0 warnings
β Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
|
commitlint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
commitlint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
pre-commit
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, asdf-vm/actions/setup@v1, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
pre-commit
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|