Skip to content

Commit

Permalink
Merge pull request #19 from greut/laravel-5.8
Browse files Browse the repository at this point in the history
Dispatcher::fire is effectively removed as of 5.8
  • Loading branch information
maherelgamil authored Apr 30, 2019
2 parents c18bc4d + c2f2137 commit b726aea
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The best and easiest way to install this package is through [Composer](https://g

### Compatibility

This package fully compatible with **[Laravel](https://laravel.com)** `5.1.*|5.2.*|5.3.*|5.4.*|5.5.x`.
This package fully compatible with **[Laravel](https://laravel.com)** `^5.4`.

### Require Package

Expand All @@ -33,7 +33,7 @@ After installing the package, open your Laravel config file located at `config/a
Buzzylab\Laradown\MarkdownServiceProvider::class,
```

> **Note:** Checkout Laravel's [Service Providers](https://laravel.com/docs/5.5/providers) and [Service Container](https://laravel.com/docs/5.5/container) documentation for further details.
> **Note:** Checkout Laravel's [Service Providers](https://laravel.com/docs/5.8/providers) and [Service Container](https://laravel.com/docs/5.8/container) documentation for further details.
And add the following to `$aliases`

Expand Down
10 changes: 5 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
"editor"
],
"require": {
"illuminate/support": "^5.1",
"illuminate/filesystem": "^5.1",
"illuminate/events": "^5.1",
"illuminate/container": "^5.1",
"illuminate/contracts": "^5.1",
"illuminate/support": "^5.4",
"illuminate/filesystem": "^5.4",
"illuminate/events": "^5.4",
"illuminate/container": "^5.4",
"illuminate/contracts": "^5.4",
"erusev/parsedown": "^1.6",
"erusev/parsedown-extra": "0.7.*"
},
Expand Down
8 changes: 4 additions & 4 deletions src/Laradown.php
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,12 @@ protected function element(array $Element)
public function convert($markdown)
{
// Fire converting event
$this->getContainer('events')->fire('laradown.entity.converting');
$this->getContainer('events')->dispatch('laradown.entity.converting');

$text = $this->text($markdown);

// Fire converted event
$this->getContainer('events')->fire('laradown.entity.converted');
$this->getContainer('events')->dispatch('laradown.entity.converted');

return $text;
}
Expand All @@ -124,7 +124,7 @@ public function render($markdown)
public function collect()
{
// Fire collecting event
$this->getContainer('events')->fire('laradown.entity.collecting');
$this->getContainer('events')->dispatch('laradown.entity.collecting');

// Make indicator true
$this->collect_indicator = true;
Expand All @@ -145,7 +145,7 @@ public function endCollect()
$markdown = ob_get_clean();

// Fire collected event
$this->getContainer('events')->fire('laradown.entity.collected');
$this->getContainer('events')->dispatch('laradown.entity.collected');

// Convert the markdown content to html
return $this->convert($markdown);
Expand Down

1 comment on commit b726aea

@Chrisx84
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot it works ty so much

Please sign in to comment.