Workaround for bug with caml_sys_argv #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a hack in the compiler that miscompiles the `caml_sys_argv` primitive if it's declared as an external directly (it's supposed to be exposed through the `"%sys_argv"` builtin primitive, not directly). I'm not sure exactly why it never was an issue before, but I believe that without this patch trying to call the `caml_sys_argv` primitive through the generated `Prim` module will cause a segmentation fault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a hack in the compiler that miscompiles the
caml_sys_argvprimitive if it's declared as an external directly (it's supposed to be exposed through the"%sys_argv"builtin primitive, not directly).I'm not sure exactly why it never was an issue before, but I believe that without this patch trying to call the
caml_sys_argvprimitive through the generatedPrimmodule will cause a segmentation fault.