Safe-string compatibility #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now depend on the 'bytes' ocamlfind package, which provides compatibility of Bytes-using code on older OCaml versions. The only place where the new code is not equivalent to the previous one is the reading of section names in index.ml: we allocate a new string for each section name read, while the previous code mutated a buffer in place. Allocating a Bytes buffer in place would be doable, but then we would use Bytes.to_string to match against section name strings (so doing an allocation in any case), or would have to use an unsafe operation in a place where that does not feel necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code changes have been tested to work on 4.00, 4.01 (using the backward-compatibility ocamlfind package for
bytes) and 4.02.