-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GuildAuditLogEntryCreate): add guild_id #1367
feat(GuildAuditLogEntryCreate): add guild_id #1367
Conversation
I rely on this change so if we can get it merged soon, that would be great. Thanks |
bump? This should be an easy merge |
Sorry for leaving this without an answer for this much time. There's currently an open PR for this, so moving forward with this PR will be only possible after that one is merged. P.S. It should be noted there's also discord/discord-api-docs#5865, however it was closed a while ago. |
Does it really matter that much if it's "undocumented"? Seems like a no-brainer to approve this merge. I really doubt this field would be omitted in a future update - it's not like audit logs are a thing outside of guilds lol. This event is pretty much useless if we don't know which guild the event is dispatched from. Kindly reconsider. |
|
@FedorLap2006 Several other libs support this feature, so there is virtually no reason not to merge this 🤔 JDA: https://docs.jda.wiki/net/dv8tion/jda/api/events/guild/GenericGuildEvent.html#getGuild() |
Also @rwhelan - it is more appropriate to implement this field on the |
The discord api docs PR for this field is now merged |
Thank you for the contribution |
Adds the field GuildID to the AuditLogEntry struct. While not documented (https://discord.com/developers/docs/resources/audit-log#audit-log-entry-object-audit-log-entry-structure) it is part of the struct sent on the wire: