Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildAuditLogEntryCreate): add guild_id #1367

Merged
merged 3 commits into from
May 26, 2024

Conversation

rwhelan
Copy link
Contributor

@rwhelan rwhelan commented Apr 20, 2023

Adds the field GuildID to the AuditLogEntry struct. While not documented (https://discord.com/developers/docs/resources/audit-log#audit-log-entry-object-audit-log-entry-structure) it is part of the struct sent on the wire:
image

@AbduAmeen
Copy link

I rely on this change so if we can get it merged soon, that would be great. Thanks

@FedorLap2006 FedorLap2006 self-assigned this Apr 24, 2023
@FedorLap2006 FedorLap2006 added the feature Major feature implementation label Apr 24, 2023
@FedorLap2006 FedorLap2006 added the undocumented Feature that is not yet documented by Discord label May 12, 2023
@rwhelan
Copy link
Contributor Author

rwhelan commented Jun 30, 2023

bump? This should be an easy merge

@rwhelan
Copy link
Contributor Author

rwhelan commented Sep 8, 2023

image

@FedorLap2006
Copy link
Collaborator

FedorLap2006 commented Oct 29, 2023

Sorry for leaving this without an answer for this much time.
We usually don't merge stuff if it's not in the API documentation.

There's currently an open PR for this, so moving forward with this PR will be only possible after that one is merged.

P.S. It should be noted there's also discord/discord-api-docs#5865, however it was closed a while ago.

@hhaste
Copy link
Contributor

hhaste commented Mar 19, 2024

Sorry for leaving this without an answer for this much time. We usually don't merge stuff if it's not in the API documentation.

There's currently an open PR for this, so moving forward with this PR will be only possible after that one is merged.

P.S. It should be noted there's also discord/discord-api-docs#5865, however it was closed a while ago.

Does it really matter that much if it's "undocumented"? Seems like a no-brainer to approve this merge. I really doubt this field would be omitted in a future update - it's not like audit logs are a thing outside of guilds lol.

This event is pretty much useless if we don't know which guild the event is dispatched from. Kindly reconsider.

@rwhelan
Copy link
Contributor Author

rwhelan commented Mar 19, 2024

Sorry for leaving this without an answer for this much time. We usually don't merge stuff if it's not in the API documentation.
There's currently an open PR for this, so moving forward with this PR will be only possible after that one is merged.
P.S. It should be noted there's also discord/discord-api-docs#5865, however it was closed a while ago.

Does it really matter that much if it's "undocumented"? Seems like a no-brainer to approve this merge. I really doubt this field would be omitted in a future update - it's not like audit logs are a thing outside of guilds lol.

This event is pretty much useless if we don't know which guild the event is dispatched from. Kindly reconsider.

image

@hhaste
Copy link
Contributor

hhaste commented Mar 31, 2024

Also @rwhelan - it is more appropriate to implement this field on the GuildAuditLogEntryCreate struct (events.go:406) rather than AuditLogEntry, since guild ID is only ever included from this particular gateway payload.

@Earlopain
Copy link
Contributor

The discord api docs PR for this field is now merged

@FedorLap2006 FedorLap2006 changed the title feat: Add GuildID field to the AuditLogEntry struct feat: add guild_id to GuildAuditLogEntryCreate event May 26, 2024
@FedorLap2006 FedorLap2006 changed the title feat: add guild_id to GuildAuditLogEntryCreate event feat(GuildAuditLogEntryCreate): add guild_id May 26, 2024
@FedorLap2006 FedorLap2006 added structs API structs and constants related changes and removed undocumented Feature that is not yet documented by Discord labels May 26, 2024
@FedorLap2006 FedorLap2006 merged commit 6af2451 into bwmarrin:master May 26, 2024
8 checks passed
@FedorLap2006
Copy link
Collaborator

Thank you for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Major feature implementation structs API structs and constants related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants