Fix session ID deadlockwhen opening a VoiceConnection #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedorLap2006
added
fix
Fix formatting of the documentation comment for VoiceConnection.Speaking function
FedorLap2006
changed the title
FedorLap2006
changed the title
|
Thanks for the contribution! |
|
I did the edits myself, to not hold it off for longer. Hope you understand and sorry for the wait. |
FedorLap2006
added a commit
that referenced
this pull request
Aug 13, 2023
* Unlock when checking voice connection sessionID to prevent deadlock * Move lock to preserve concurrency safety, while allowing the sessionID to be populated * style: formatting Fix formatting of the documentation comment for VoiceConnection.Speaking function * feat: reword explanatory comment --------- Co-authored-by: Fedor Lapshin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #829
When checking the Voice Session ID in
VoiceConnection.open(), the sessionID is populated asynchronously when websocket messages come in, see wsapi.go.However,
open()still holds the lock on the session, so the ID can never be populated, and we loop and accomplish nothing until releasing the lock upon exiting the function.This PR addresses this deadlock bug by momentarily releasing the lock anytime the process sleeps, allowing other processes to populate the sessionID appropriately - while not sacrificing concurrency safety by releasing the lock entirely.