Add new permissions #1411
Merged
Add new permissions #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedorLap2006
added
refactor
improvement
|
The 2 permissions I added in the last commit are no longer undocumented, the PR for that has been merged. |
|
just a thought, maybe moving all these permissions from structs.go to a new file, like permissions.go? |
Closed
FedorLap2006
requested changes
Jun 22, 2024
structs.go
Outdated
Comment on lines
2250
to
2545
| // Allows management and editing of the guil. | ||
| PermissionManageServer = 1 << 5 |
There was a problem hiding this comment.
Suggested change
| // Allows management and editing of the guil. | |
| PermissionManageServer = 1 << 5 | |
| // Deprecated: PermissionManageServer has been replaced by PermissionManageGuild. | |
| PermissionManageServer = 1 << 5 | |
| // Allows management and editing of the guild. | |
| PermissionManageGuild = 1 << 5 |
Earlopain
force-pushed
the
new-permissions
branch
from
10540e6
to
bf8326f
Compare
FedorLap2006
requested changes
Jun 22, 2024
structs.go
Outdated
| PermissionSendVoiceMessages = 1 << 46 | ||
|
|
||
| // Allows sending polls. | ||
| PermissionSendPools = 1 << 49 |
There was a problem hiding this comment.
Eugh, thanks for catching this
There was a problem hiding this comment.
No problem! We all do this sometimes.
Earlopain
force-pushed
the
new-permissions
branch
from
bf8326f
to
ac93da5
Compare
FedorLap2006
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit makes the numbers bitflags which I find easier to parse and follows all the other flags in the repo. I also added docs for them.
Second commit adds missing flags currently documented at https://discord.com/developers/docs/topics/permissions#permissions-bitwise-permission-flags
Third commit renames some fields to what they are now called on discords docs page.
Fourth commit adds currently undocumented flags, but there is a pending pr for those at discord/discord-api-docs#6305