Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for integration events #1545

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

Suhaibinator
Copy link
Contributor

@Suhaibinator Suhaibinator commented Jul 13, 2024

Discordgo does not currently support Integration creates, updates, and deletes. This PR adds support for that.

See also

@Suhaibinator
Copy link
Contributor Author

@FedorLap2006

@FedorLap2006 FedorLap2006 self-assigned this Jul 28, 2024
@FedorLap2006 FedorLap2006 added gateway Gateway related issues and pull requests missing Missing fields, endpoints, etc labels Jul 28, 2024
events.go Show resolved Hide resolved
events.go Show resolved Hide resolved
events.go Outdated Show resolved Hide resolved
events.go Outdated

// IntegrationDelete is the data for a IntegrationDelete event.
type IntegrationDelete struct {
*Integration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The payload isn't an Integration object. Rather it's

Suggested change
*Integration
ID string `json:"id"`
GuildID string `json:"guild_id"`
ApplicationID string `json:"application_id,omitempty"`

P.S. This is unformatted.

@Suhaibinator
Copy link
Contributor Author

@FedorLap2006 requested changes have been made

@Suhaibinator
Copy link
Contributor Author

@FedorLap2006 do you know why it is saying that the format check failed?

Also it seems I am not able to merge the PR. Does the merge have to be performed by a maintainer?

@FedorLap2006 FedorLap2006 merged commit d23158b into bwmarrin:master Jul 29, 2024
8 checks passed
@Suhaibinator Suhaibinator deleted the suhaibinator-new-events branch August 29, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gateway Gateway related issues and pull requests missing Missing fields, endpoints, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants