Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-Commenting code for Components/Box #1508

Closed
wants to merge 1 commit into from
Closed

Self-Commenting code for Components/Box #1508

wants to merge 1 commit into from

Conversation

yashovardhankapoor
Copy link

Types of Changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • [ x] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • [ x] Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

I have looked over at Issue #1324 and just self documented right now for components/Box and want some feedback so i can continue for the rest of the components.

@brettdorrans
Copy link
Member

Hello @yashovardhankapoor and thanks for your PR. It looks like you've run the file through a LLM like ChatGPT and doesn't really improve much, so I'll close it. Please feel free to consider other contributions in future, but in general I'd prefer not to tinker like this with automated code improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants