[POC] macOS support #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't for the life of me figure out how to point the VS code cargo task towards the correct zsh environment. It never finds yarn, no matter how often I set the default with nvm and modify PATH / run the nvm init command within .zshrc. I feel like this is just broken. Everything works in the terminal, also in the VS code terminal, just not from whatever context cargo tries to invoke yarn. As I have no control over the cargo task implementation in VS code, I will just instruct it to use npm instead (sadly)
Wow, this was a VS code issue all along. It does not by default use any user profile. This means, while everything works fine in the VS Code terminal, it does not from tasks. Some user settings in JSON fixed it. Hopefully the following link will be stable for future poor souls to come: https://discord.com/channels/1126689848426774572/1200559005291004014/1305137704274628640
React1-X
added
macOS
React1-X
requested changes
Nov 18, 2024
(To be removed again, just for reference)
…ating executable and package paths And some debug printing, that should be removed in the future
Needs to be tested and refactored
…time), package extraction in own module
No idea why they weren't the same before
|
|
||
| VOLUME=`hdiutil attach -nobrowse "$1" | grep Volumes | cut -f 3` | ||
| cp -rf "$VOLUME"/*.app "$2" | ||
| hdiutil detach "$VOLUME" |
There was a problem hiding this comment.
This script is never used?
|
Waiting impatiently for this, @janerjak u the real mvp 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Flash Player.appis already installed in/Applications, we are able to launch the main executable contained within directly from the launcher.It will be interesting to see if there is a way to also automatically install Flash Player via
.dmg. See:https://discord.com/channels/1126689848426774572/1305270501589123176
Note that there are some unnecessary debug artifacts still within this PR that will be cleaned up in the near future