Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make healthy check work properly #246

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

h3n4l
Copy link
Member

@h3n4l h3n4l commented Dec 3, 2023

The health check command will execute within the container, so we need to access the port that the Bytebase application uses. Additionally, a 10-second timeout should suffice for a basic HTTP request.

Copy link

vercel bot commented Dec 3, 2023

@h3n4l is attempting to deploy a commit to the bytebase Team on Vercel.

A member of the Team first needs to authorize it.

@h3n4l h3n4l requested review from tianzhou and d-bytebase December 3, 2023 08:40
Copy link
Contributor

@tianzhou tianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianzhou tianzhou merged commit d2b7402 into bytebase:main Dec 3, 2023
1 check failed
@h3n4l h3n4l deleted the fix/health-check branch December 3, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants