Make request_modifier usable from async trait #711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frank-hivewatch
force-pushed
the
feature/decorate_request_modifier
branch
from
a95b999 to
b2a07ea
Compare
frank-hivewatch
force-pushed
the
feature/decorate_request_modifier
branch
2 times, most recently
from
5039468 to
fefcd06
Compare
The request_modifier must be thread safe when called from async trait.
frank-hivewatch
force-pushed
the
feature/decorate_request_modifier
branch
from
fefcd06 to
c4640d3
Compare
|
can we merge this, because this is actual a breaking change from 0.22 to 0.23. Would be nice to get it fixed again. |
|
Hey @frank-hivewatch , apologies for super late reply! as of now, the changes done in this PR are incorporated in fn signature!: Line 53 in f7c7793 so I will close the PR. Thank you so much for the contribution and sorry once again for the PR going unnoticed 😅 @Siddius this changes will be available in 0.24 ( expect it to be released next week ). Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch decorates the request_modifier with Send + Sync markers.
The request_modifier must be thread safe when called from async trait.
Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.