Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rumqttc/examples): Fix rumqttc async_manual_acks.rs #739

Merged

Conversation

jliklik
Copy link
Contributor

@jliklik jliklik commented Oct 25, 2023

  • Allow code to continue after first loop finishes

Type of change

  • Miscellaneous (related to maintenance)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

- Allow code to continue after first loop finishes
- Allow program to terminate after all pubacks have been sent
@jliklik jliklik marked this pull request as ready for review October 25, 2023 18:34
Copy link
Member

@swanandx swanandx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, please go through review comment and feel free to let me know what do you think.

rumqttc/examples/async_manual_acks.rs Outdated Show resolved Hide resolved
@swanandx swanandx merged commit eaba670 into bytebeamio:main Oct 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants