Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rumqttd): Implement constant-time password comparison #829

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Inventor77
Copy link
Member

Fixes #796

Password Authentication in constant time using subtle::ConstantTimeEq

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

Copy link
Member

@swanandx swanandx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the PR 🚀

@swanandx swanandx merged commit 3c9b4f9 into main Mar 26, 2024
3 of 4 checks passed
@swanandx swanandx deleted the add-constant-time-password-comparison branch March 26, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password authentication is not constant-time
2 participants