-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual ACK packet support #855
base: main
Are you sure you want to change the base?
Conversation
Are there any additional comments or feedback? If this solution is acceptable, could you please advise on the steps I can take to expedite the merging process? |
Added some docs about the API usage. Please check. |
Any comments? |
Any comments on manual ACK with reason code support here? |
Is there any chance to merge this PR? It appears to be relatively independent and should not affect other ongoing discussions. |
Hello, is there anything else needed to move this PR forward? |
A solution for issue #841 and issue #609.
Note the example of
async_manual_acks_v5
needs PR #854 to make broker re-send publishes.Type of change
New feature (non-breaking change which adds functionality)
get_manual_ack
to return manual ack packet whereset_reason
/set_code
to update reason codeset_reason_string
to set reason stringset_user_properties
to set user propertiesmanual_ack
/try_manual_ack
to send the modified packet (PUBACK/PUBREC) returned byget_manual_ack
Checklist:
cargo fmt
CHANGELOG.md
if it's relevant to the users of the library. If it's not relevant mention why.