Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for rumqttc. #911

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Update dependencies for rumqttc. #911

merged 2 commits into from
Dec 19, 2024

Conversation

qwandor
Copy link
Contributor

@qwandor qwandor commented Sep 23, 2024

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Miscellaneous (related to maintenance)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

@qwandor
Copy link
Contributor Author

qwandor commented Nov 21, 2024

Any idea what's going on with the Windows build failure here? I don't have access to a Windows system to test locally.

@swanandx
Copy link
Member

Any idea what's going on with the Windows build failure here? I don't have access to a Windows system to test locally.

error: failed to run custom build command for `aws-lc-sys v0.21.2`

build for aws-lc-sys is failing because it couldn't find nasm on windows.

updating rustls would be the cause for it iirc they moved to using aws-lc-sys backend or something!

@qwandor
Copy link
Contributor Author

qwandor commented Nov 21, 2024

Looks like updating further fixed the issue. Can this be merged and released soon?

@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 12417648028

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 111 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.01%) to 36.092%

Files with Coverage Reduction New Missed Lines %
rumqttc/src/eventloop.rs 7 84.19%
rumqttd/src/link/timer.rs 8 0.0%
rumqttd/src/link/remote.rs 25 46.43%
rumqttc/src/v5/eventloop.rs 28 7.55%
rumqttd/src/link/bridge.rs 43 0.0%
Totals Coverage Status
Change from base Build 10511632669: -0.01%
Covered Lines: 5984
Relevant Lines: 16580

💛 - Coveralls

@qwandor
Copy link
Contributor Author

qwandor commented Dec 19, 2024

Is there anything else needed to get this merged and released?

rumqttc/CHANGELOG.md Outdated Show resolved Hide resolved
@swanandx swanandx merged commit 4262e6a into bytebeamio:main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants