Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cmake from build requirements #829

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Removing cmake from the list of things that need to be installed to build Javy.

Why am I making this change?

cmake does not appear to be necessary. Or at least I was able to build Javy on a fresh Ubuntu 24.04 without it.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-plugin do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember what introduced the need for cmake? I'm just wondering if the root cause is known and we can confidently remove this dependency from the docs. If we're no confident about the root cause, perhaps we can consider keeping this around? Going back in history, it seems that binaryen-rs is what introduced the cmake dependency, we have now migrated to wasm-opt-rs, so I think we should be good.

@jeffcharles
Copy link
Collaborator Author

It looks like it was binaryen-rs to me as well. FWIW, a fresh docker image of Ubuntu 24.04 does not have cmake installed and Javy will build on it without any errors. I'm skeptical that there would be some dependency that would require cmake but only on MacOS.

@jeffcharles jeffcharles merged commit 080b9a0 into main Nov 19, 2024
7 checks passed
@jeffcharles jeffcharles deleted the jc.remove-cmake-from-from-deps branch November 19, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants