Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower fuel consumption threshold from 10% to 2% #839

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Lower fuel consumption threshold from 10% to 2% #839

merged 1 commit into from
Nov 25, 2024

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Reducing threshold in fuel usage checks from 10% to 2%.

Why am I making this change?

We want to make sure we don't miss larger increases in fuel usage.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-plugin do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles force-pushed the jc.lower-fuel-regression-threshold branch from 66727ce to 180c805 Compare November 25, 2024 18:59
@jeffcharles jeffcharles marked this pull request as ready for review November 25, 2024 19:18
@jeffcharles jeffcharles merged commit 96a7951 into main Nov 25, 2024
7 checks passed
@jeffcharles jeffcharles deleted the jc.lower-fuel-regression-threshold branch November 25, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulecabrera saulecabrera saulecabrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffcharles @saulecabrera