Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CI workflows #841

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Simplify CI workflows #841

merged 1 commit into from
Nov 27, 2024

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

This is an attempt at simplifying the CI workflows. Instead of using two jobs for CI, it switches to one. We used two because we used to compile the plugin with MacOS but do the CLI integration testing with Linux. But now we compile the plugin with Linux so we can reuse the same job. I've also moved the WPT tests because they can just re-use the same artifact we've built in the CI pipeline to run the WPT test suite so we don't need a separate workflow. We used to need a separate one because the WPT test suite required Javy to be built with an experimental_event_loop feature enabled but that's not the case any more. I've also inlined the shared CI setup since there's only one user of it now.

Why am I making this change?

Less workflows to manage and reducing the jobs from two to one should speed up CI a bit.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-plugin do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles marked this pull request as ready for review November 27, 2024 16:26
@jeffcharles jeffcharles merged commit e4f3a12 into main Nov 27, 2024
4 checks passed
@jeffcharles jeffcharles deleted the jc.simplify-ci branch November 27, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants